Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule): add additional elements to check for incomplete with required children #1547

Merged
merged 3 commits into from
May 15, 2019
Merged

feat(rule): add additional elements to check for incomplete with required children #1547

merged 3 commits into from
May 15, 2019

Conversation

scurker
Copy link
Member

@scurker scurker commented May 6, 2019 •
edited by straker
Loading

Closes issue: #1444
Closes issue: #383

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Steve

@jeeyyy
Copy link
Contributor

jeeyyy commented May 7, 2019 •
edited
Loading

@scurker are we now saying raise a needs review for an element with no owned elements, as against a failure? eg: <ul></ul>?

We are authoring couple of rules in ACT Rules, for owned elements & context elements, and ideally would like to match our implementation with expected results of test cases from here - https://github.com/act-rules/act-rules.github.io/pull/245/files

@WilcoFiers - wdyt?

WilcoFiers
WilcoFiers previously requested changes May 10, 2019
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a missing test, LGTM.

lib/checks/aria/required-children.js Show resolved Hide resolved
@scurker scurker dismissed WilcoFiers’s stale review May 13, 2019 16:39

Added additional check tests

@scurker scurker merged commit 3726901 into develop May 15, 2019
@scurker scurker deleted the aria-required-children-rule branch May 15, 2019 15:21
stephenmathieson added a commit that referenced this pull request May 16, 2019
@stephenmathieson
Merge branch 'develop' into stephenmathieson-patch-1
b697373 
* develop:
  test: fix test for Safari (#1557)
  test: fix flakey test (#1573)
  test: fix tests failing in IE11 (#1570)
  test: only run IE11 tests in appveyor (#1571)
  chore: run prettier and format (#1568)
  test: disable es6 syntax usage within tests directory (#1569)
  feat(rule): add additional elements to check for incomplete with required children (#1547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

@WilcoFiers WilcoFiers WilcoFiers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scurker @jeeyyy @WilcoFiers @straker